Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: cleanup and add en_US.UTF-8 locale #98

Merged
merged 1 commit into from Mar 7, 2019
Merged

Dockerfile: cleanup and add en_US.UTF-8 locale #98

merged 1 commit into from Mar 7, 2019

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Mar 7, 2019

Closes #84
Closes #83

Thanks @xMrWhite, @frol and @sr229.

@nhooyr
Copy link
Contributor Author

nhooyr commented Mar 7, 2019

CI failures are related to rate limits so merging this anyway. @kylecarbs is this a known issue?

@nhooyr nhooyr merged commit 14f1230 into coder:master Mar 7, 2019
@nhooyr nhooyr deleted the docker branch March 7, 2019 19:08
@kylecarbs
Copy link
Member

Yup its known. I've attempted to find a good solution. Might need to jank within the CI.

@Omeryl
Copy link
Contributor

Omeryl commented Mar 7, 2019

@kylecarbs Unrelated to this issue, but I didn't see another one referencing that problem:

Have you tried using travis-ci's caching mechanism? It'd reduce the number of calls your throwing to NPM I believe.

https://docs.travis-ci.com/user/caching/ is the full documentation.

It is generally as simple as adding this to your ci file: cache: npm.

@kylecarbs
Copy link
Member

Hmm. Will add this. Thanks @Omeryl !

code-asher pushed a commit that referenced this pull request Jun 19, 2019
Dockerfile: cleanup and add en_US.UTF-8 locale
jsjoeio pushed a commit that referenced this pull request Jun 1, 2021
 Pasted "Publishing A Release" in the 'MAINTAINING.md' file from line #98
jsjoeio pushed a commit that referenced this pull request Jun 1, 2021
 Pasted "Publishing A Release" in the 'MAINTAINING.md' file from line #98
jsjoeio pushed a commit that referenced this pull request Jun 1, 2021
 Pasted "Publishing A Release" in the 'MAINTAINING.md' file from line #98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants